Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codesandbox preview is unavaliable for public #847

Closed
himself65 opened this issue Jan 25, 2023 · 5 comments
Closed

codesandbox preview is unavaliable for public #847

himself65 opened this issue Jan 25, 2023 · 5 comments
Assignees
@doodlewind
Labels
type:bug Something isn't working

Comments

@himself65
Copy link
Contributor

No description provided.

@himself65 himself65 added the type:bug Something isn't working label Jan 25, 2023
@himself65
Copy link
Contributor Author

Refs: https://codesandbox.io/docs/learn/integrations/github-app#privacy-and-permissions

@doodlewind
Copy link
Member

doodlewind commented Jan 26, 2023 •
edited
Loading

I think it's working as intended for now. Take #858 as an example, the CodeSandbox link in this PR ( https://codesandbox.io/p/github/toeverything/blocksuite/0126/build?workspace=%7B%22gitSidebarPanel%22:%22PR%22,%22sidebarPanel%22:%22GIT%22%7D ) works in incognito tab. Not sure if I am misunderstanding the "public preview" here, could you elaborate?

Also, the permission of CodeSandbox app should be correct:

image

@himself65
Copy link
Contributor Author

image

@lawvs
Copy link
Collaborator

lawvs commented Jan 26, 2023

The URL https://codesandbox.io/p/github/toeverything/blocksuite/0126/build?file=%2FREADME.md works on my machine.

Screenshot 2023-01-26 at 11 57 40 PM

But the actual code sandbox link in PR such as #851 not work.

https://codesandbox.io/p/github/toeverything/blocksuite/20230125-tsc?workspace=%7B%22gitSidebarPanel%22:%22PR%22,%22sidebarPanel%22:%22GIT%22%7D

Screenshot 2023-01-26 at 11 59 54 PM

@doodlewind
Copy link
Member

@himself65 are we good to close this one if things work you there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doodlewind doodlewind

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doodlewind @himself65 @lawvs