refactor(infra): directory structure #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
mod:infra
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 461849e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Deploying with
|
| Latest commit: |
461849e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89465a46.affine-dev.pages.dev |
| Branch Preview URL: | https://refactor-directory-structure.affine-dev.pages.dev |
joooye34
force-pushed
the
refactor/directory-structure
branch
2 times, most recently
from
4b63da9 to
742a4ab
Compare
github-actions
bot
added
mod:component
and removed
mod:infra
himself65
force-pushed
the
refactor/directory-structure
branch
from
24644aa to
742a4ab
Compare
joooye34
force-pushed
the
refactor/directory-structure
branch
from
742a4ab to
bf422ef
Compare
joooye34
force-pushed
the
refactor/directory-structure
branch
from
6def7e7 to
461849e
Compare
pengx17
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign directory structure:
packages/contains all code running in production.backend/contains backend code, more information from https://github.com/toeverything/OctoBase.frontend/contains frontend code, including the web app, the electron app and business libraries.plugins/contains all build-in plugins.commoncontains the isomorphic code or basic libraries without business.tools/contains tools to help developing or CI, not used in production.tests/contains testings across different libraries, including e2e testings and integration testings.Libraries movement:
storagetobackendthis lib just used in affine backend businessgraphqltofrontendgenerate api code for affine fronthookstofrontendseparate packages to have more stricter specificationsnativetofrontendrust lib for electron appi18ntofrontendall local translations for affinetemplatestofrontendworkspace initialization templatesworkspacetofrontendworkspace storage logic for affineclitotoolsdevelop tool for affine monorepoplugin-clitotoolsdevelop tool for affine plugin, not public one nowworkerstotoolsused in github workflowstorybooktotestsused for product acceptance in CI stage, as part of integration testingLibraries keeping in common temporarily:
debugmaybe removeenvmaybe removeinfranot thought it through yet