Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule test-directory-exists fails on remote repos but passes on local repos #142

Closed
DuaneOBrien opened this issue Mar 4, 2019 · 1 comment

Comments

@DuaneOBrien
Copy link
Contributor

DuaneOBrien commented Mar 4, 2019

Issue Report

When running repolinter against a remote directory, the "test-directory-exists" rule appears to always fail, even when it passes on a local clone of the repo.

Expected Behavior

Results from local test:

Target directory: /home/duaneo/Code/working/repolinter
Ruleset: ../../../repolint.json
✔ test-directory-exists: found (node_modules/array-from/test.js)

Actual Behavior

Results from remote test:

Target directory: /home/duaneo/Code/working/repolinter/tmp/23cb2e61-589e-418d-8368-911aabab5e5a
Ruleset: ../../../../../repolint.json
✖ test-directory-exists: not found: (**/test*, **/specs)

Steps to Reproduce the Issue

repolint.json :

{ "axioms": { "linguist":"language", "licensee":"license", "packagers":"packager" }, "rules": { "all": { "test-directory-exists:directory-existence": ["error", {"directories": ["**/test*", "**/specs"], "nocase": true}] } } }

OS: Ubuntu 18.04.2 LTS
node: v8.10
npx: 10.2.0
npm: 3.5.2
ruby: 2.5.1p57

@prototypicalpro
Copy link
Collaborator

I believe this was fixed in #174. Please leave a comment if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants