From 6589a7f595c970381ed3933b8b059e92e012eaa3 Mon Sep 17 00:00:00 2001 From: Todd Lipcon Date: Wed, 21 Mar 2018 15:35:17 -0700 Subject: [PATCH] symbolz: skip un-symbolizable mappings This fixes https://github.com/google/pprof/issues/339 by skipping attempts to symbolize anything from system mappings like [vdso], [vsyscall], etc. --- internal/symbolz/symbolz.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/internal/symbolz/symbolz.go b/internal/symbolz/symbolz.go index 086c0ccb0..6f61d88d0 100644 --- a/internal/symbolz/symbolz.go +++ b/internal/symbolz/symbolz.go @@ -45,6 +45,10 @@ func Symbolize(p *profile.Profile, force bool, sources plugin.MappingSources, sy // Only check for HasFunctions as symbolz only populates function names. continue } + // Skip well-known system mappings + if m.Unsymbolizable() { + continue + } mappingSources := sources[m.File] if m.BuildID != "" { mappingSources = append(mappingSources, sources[m.BuildID]...)