-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save scrollback and start logging as single function #39
base: master
Are you sure you want to change the base?
Conversation
Updated PR to fix #38 as well |
OK, got carried away. Added README updates, and key bindings for the snapshot_and_log. |
Can I get a review on this? Enabling shows this on the statusline:
Lets you "forget" to enable logging for an important thing, then go back and log the whole scrollback buffer and start logging everything after that. |
Is there a way to stop the logging once it has began using the I think it might be good to integrate an additional stop function. While not a necessity it would be full featured to do so. Looks like would need to track whether we are already logging with a similar yet new function to the I will take a look if i can get some time, but wanted to post here to see if there was something I was missing before trying to implement it myself. |
@codydiehl, I agree completely. |
Fixes #31
Note that a cleaner solution may be to restructure the toggle/start scripts so that the block I added didn't need to replicate the context read that already exists in the toggle script.