From b44455f7e4f556a69a339d7b8fdc01d58e56b8b3 Mon Sep 17 00:00:00 2001
From: jimmy <aiwei18@gmail.com>
Date: Wed, 13 Feb 2019 21:43:39 +0800
Subject: [PATCH] log span only if err

---
 service/dynamodb/api.go | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/service/dynamodb/api.go b/service/dynamodb/api.go
index 495da4f8f71..196e286f377 100644
--- a/service/dynamodb/api.go
+++ b/service/dynamodb/api.go
@@ -184,12 +184,15 @@ func (c *DynamoDB) BatchGetItem(input *BatchGetItemInput) (*BatchGetItemOutput,
 func (c *DynamoDB) BatchGetItemWithContext(ctx aws.Context, input *BatchGetItemInput, opts ...request.Option) (*BatchGetItemOutput, error) {
 	span, ctx := opentracing.StartSpanFromContext(ctx, "BatchGetItemWithContext")
 	defer span.Finish()
-	span.LogFields(log.Object("request:", input))
 
 	req, out := c.BatchGetItemRequest(input)
 	req.SetContext(ctx)
 	req.ApplyOptions(opts...)
-	return out, req.Send()
+	err := req.Send()
+	if err != nil {
+		span.LogFields(log.Object("request:", input))
+	}
+	return out, err
 }
 
 // BatchGetItemPages iterates over the pages of a BatchGetItem operation,
@@ -2327,12 +2330,16 @@ func (c *DynamoDB) GetItem(input *GetItemInput) (*GetItemOutput, error) {
 func (c *DynamoDB) GetItemWithContext(ctx aws.Context, input *GetItemInput, opts ...request.Option) (*GetItemOutput, error) {
 	span, ctx := opentracing.StartSpanFromContext(ctx, "GetItemWithContext")
 	defer span.Finish()
-	span.LogFields(log.Object("request:", input))
 
 	req, out := c.GetItemRequest(input)
 	req.SetContext(ctx)
 	req.ApplyOptions(opts...)
-	return out, req.Send()
+
+	err := req.Send()
+	if err != nil {
+		span.LogFields(log.Object("request:", input))
+	}
+	return out, err
 }
 
 const opListBackups = "ListBackups"
@@ -4841,12 +4848,16 @@ func (c *DynamoDB) UpdateItem(input *UpdateItemInput) (*UpdateItemOutput, error)
 func (c *DynamoDB) UpdateItemWithContext(ctx aws.Context, input *UpdateItemInput, opts ...request.Option) (*UpdateItemOutput, error) {
 	span, ctx := opentracing.StartSpanFromContext(ctx, "UpdateItemWithContext")
 	defer span.Finish()
-	span.LogFields(log.Object("request:", input))
 
 	req, out := c.UpdateItemRequest(input)
 	req.SetContext(ctx)
 	req.ApplyOptions(opts...)
-	return out, req.Send()
+
+	err := req.Send()
+	if err != nil {
+		span.LogFields(log.Object("request:", input))
+	}
+	return out, err
 }
 
 const opUpdateTable = "UpdateTable"