Browserified jsdom cannot execute <script> tags #1023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did a thing, it works, pls comment. See https://travis-ci.org/tmpvar/jsdom/builds/50547517 for the proper build with browser test. |
|
Wow, looks pretty awesome :D. Maybe add a test for async access within some nested scopes? |
|
|
||
| var globals = findGlobals(ast); | ||
| for (var i = 0; i < globals.length; ++i) { | ||
| if (globals[i].name === "window") continue; |
There was a problem hiding this comment.
curlies and newline. JSHint should be catching this? Can we JSHint this file now?
Sebmaster
force-pushed
the
fix/execution-context
branch
from
f0e129c to
5ef69ce
Compare
|
Fixed the nitpicks, but need to get some sleep before I add a test. Will do later tonight though. |
Sebmaster
force-pushed
the
fix/execution-context
branch
2 times, most recently
from
1674775 to
f75ee37
Compare
|
Added the async test. |
This dynamically rewrites the provided source code to always refer to window if it's a global variable. Caveats: * toString() of functions will return different results: a "window." prefix on global vars and whitespace modifications * Refering to undefined variables will not throw an error due to the window prefix for now. This might be fixable by throwing the error ourselves.
We can successfully run more parts of our node test suite on the browser too now! Also updated a few of the comments of the suites I've tried.
Sebmaster
force-pushed
the
fix/execution-context
branch
from
f75ee37 to
4546b8d
Compare
|
Fixed, at least somewhat, with 0ec0d0e. Will try to track down more cases as they pop up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our contextify-shim.js doesn't even have a run function. I tried to add one, just
but this of course doesn't work since it's running the code in the global scope (e.g. in a worker), where variables like
windowanddocumentdon't work right.