From 2f0707481cdc2523fd4a5c73c0e1b98a41bff75b Mon Sep 17 00:00:00 2001 From: Thomas More Date: Fri, 1 Mar 2024 16:14:29 -0500 Subject: [PATCH] Don't import SMS messages with multiple recipients Addresses: #159 --- README.md | 4 ++++ .../java/com/github/tmo1/sms_ie/ImportExportMessages.kt | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/README.md b/README.md index 8ea8908..c928bed 100644 --- a/README.md +++ b/README.md @@ -247,6 +247,10 @@ java.lang.IllegalArgumentException: The non-sync-callers AND non-blocked-url sho ``` For a possible solution, see [here](https://github.com/tmo1/sms-ie/issues/103#issuecomment-1620890135). +#### SMS Messages With Multiple Recipients + +SMS messages with multiple recipients are currently not handled entirely correctly; see [issue #159](https://github.com/tmo1/sms-ie/issues/159) for details and the current status of support for such messages. + ## Translations SMS Import / Export has been translated (from the original English) into the following languages (note that some of these translations may contain inaccuracies, due to changes to the app's original text since they were made): diff --git a/app/src/main/java/com/github/tmo1/sms_ie/ImportExportMessages.kt b/app/src/main/java/com/github/tmo1/sms_ie/ImportExportMessages.kt index 13cde42..5e6ca16 100644 --- a/app/src/main/java/com/github/tmo1/sms_ie/ImportExportMessages.kt +++ b/app/src/main/java/com/github/tmo1/sms_ie/ImportExportMessages.kt @@ -388,6 +388,12 @@ suspend fun importMessages( Log.d(LOG_TAG, "Skipping due to debug settings") return@JSONLine } + // I haven't been able to figure out how to properly insert SMS messages with multiple recipients + // https://github.com/tmo1/sms-ie/issues/159 + if (messageJSON.optString(Telephony.Sms.ADDRESS).split(" ").size > 1) { + Log.d(LOG_TAG, "SMS has multiple recipients - skipping") + return@JSONLine + } if (deduplication) { val smsDuplicatesCursor = appContext.contentResolver.query( Telephony.Sms.CONTENT_URI,