Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing -java platform variant in 0.6.1 release #72

Open
kares opened this issue Jul 1, 2021 · 8 comments
Open

missing -java platform variant in 0.6.1 release #72

kares opened this issue Jul 1, 2021 · 8 comments

Comments

@kares
Copy link

kares commented Jul 1, 2021

Version https://rubygems.org/gems/http_parser.rb/versions/0.6.1 was pushed today.
However only the MRI variant - the JRuby (-java) platfom version was not released.

Could we gem a proper release including the -java version pushed, please? // cc @ashie
❤️

@ashie
Copy link
Collaborator

ashie commented Jul 1, 2021

JRuby version is currently broken, so I skipped releasing v0.6.1 for JRuby.
I'll try to fix it, but might not release it anymore...

@kares
Copy link
Author

kares commented Jul 1, 2021

thanks for the reply, that might be an issue for folks not having the version locked to 0.6.0
as bundle install picks the latest - finds 0.6.1 and will attempt to build a C extension -> leading to an error under JRuby.

maybe if this wasn't a patch release it would have played out nicer, e.g. http gem used to depend on http_parser.rb ~> 0.6.0 and thus is now effectively broken ... 😿

@ashie
Copy link
Collaborator

ashie commented Jul 1, 2021

Thanks for the report.
I've yanked v0.6.1.

@ashie
Copy link
Collaborator

ashie commented Jul 1, 2021

I'll release MRI version as v0.7.0.

BTW one of problem of JRuby version is described in #42 (comment)
on_status is added to ParserSettings but I can't find fork of http_parser.java which implements it.
In addition, some other tests are also failed.
I'm now investigating them.

@ashie
Copy link
Collaborator

ashie commented Jul 14, 2021

I'm now investigating them.

#73

@nfrankel
Copy link

http_parser 0.7.0 and 0.8.0 have been released without Java integration. Is there anything that the community can help with?

@headius
Copy link

headius commented Aug 29, 2023

We have gotten other reports about this gem dropping JRuby support. What can I do to help update it and get JRuby support restored?

@ashie
Copy link
Collaborator

ashie commented Aug 30, 2023

Still 3 tests are failed on JRuby: #75

Since CI for JRuby has been disabled for a long time, I'm not sure when did they break and who broke them.
I'm happy if someone could help investigating & fix them.

Because 0.7.0 & 0.8.0 don't include meaningful changes for JRuby, I don't have high priority to do them for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants