Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't parse CONNECT www.google.de: HTTP/1.0 #44

Open
jan opened this issue Sep 29, 2015 · 0 comments
Open

Can't parse CONNECT www.google.de: HTTP/1.0 #44

jan opened this issue Sep 29, 2015 · 0 comments

Comments

@jan
Copy link

jan commented Sep 29, 2015

A client sends this request:

CONNECT www.google.de: HTTP/1.0
Proxy-Authorization: Basic FAKEX2tleTphcGlfa2V5X3Rlc3RfdXNlcg==

Notice the colon after www.google.de:. It works if there is a port number after the colon www.google.de:443.

The message is Could not parse data entirely (22 != 100) and the colon is the 22nd char.

I realise that the message above is probably malformed, but I'm not sure about that as I didn't find the relevant RFC yet. Still as we try to be robust in what data we accept, I could see this being accepted by http_parser.rb. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant