Skip to content

Commit

Permalink
Remove superfluous call to #create_new_auth_token.
Browse files Browse the repository at this point in the history
 * There was prior discussion around removing this line of code, inside
   lynndylanhurley#990.
   See: lynndylanhurley#990 (comment)

 * While line in question _is_ superfluous, removing it was blocked by a
   bad test.  This test was corrected in the previous commit (9ebc5bd).
  • Loading branch information
Evan-M committed Mar 19, 2018
1 parent 9ebc5bd commit aa96588
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ def set_user_by_token(mapping=nil)
if devise_warden_user && devise_warden_user.tokens[@client_id].nil?
@used_auth_by_token = false
@resource = devise_warden_user
@resource.create_new_auth_token
# REVIEW: The following line _should_ be safe to remove;
# the generated token does not get used anywhere.
# @resource.create_new_auth_token
end
end

Expand Down

0 comments on commit aa96588

Please sign in to comment.