Support using private keys that are not stored in files. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jborean93
reviewed
Sep 9, 2024
|
@jborean93 would you be interested in writing up a code snippit that we can add to a |
|
Sure when I get time I'll look at adding that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the key store use-case described in #205 (comment).
This adds support for implementing such keys by deriving from
PrivateKeyCredential.We re-use the BCL
RSAandECDsaclasses as abstractions for the key operations.The implementation can be enhanced latter on by introducing our own abstractions for the key types. This would enable async key operations, and supporting key types the BCL has no abstraction for (like ED25519).
@jborean93 ptal.