Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Leak #38

Open
TheRealMal opened this issue May 24, 2024 · 0 comments
Open

[Bug] Leak #38

TheRealMal opened this issue May 24, 2024 · 0 comments

Comments

@TheRealMal
Copy link

You call io.Pipe() at

grpc-websocket-proxy/wsproxy/websocket_proxy.go

Line 186 in 673ab2c

requestBodyR, requestBodyW := io.Pipe()

then you lose it at

grpc-websocket-proxy/wsproxy/websocket_proxy.go

Line 188 in 673ab2c

if err != nil {

(When error happens at http.NewRequestWithContext you don't close requestBodyW and responseBodyW)

io.Pipe docs
https://pkg.go.dev/io#Pipe
@TheRealMal TheRealMal changed the title [Bug] [Bug] Leak May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheRealMal