Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably a mistake in example #26

Open
dnovikoff opened this issue Oct 22, 2020 · 1 comment
Open

Probably a mistake in example #26

dnovikoff opened this issue Oct 22, 2020 · 1 comment

Comments

@dnovikoff
Copy link

dnovikoff commented Oct 22, 2020

Probably the example service should be.

service EchoService {
  rpc Echo(stream EchoRequest) returns (stream EchoResponse) {
    option (google.api.http) = {get: "/echo"};
  }
  rpc Stream(Empty) returns (stream EchoResponse) {
    option (google.api.http) = {get: "/stream"};
  }
  rpc Heartbeats(stream Empty) returns (stream Heartbeat) {
    option (google.api.http) = {post: "/heartbeats"};
  }
}

Because now both Echo and Stream methods points to the same /echo location. Also the echo should probably be get not post based on what i have tested with JS example.

I could have make a PR, but I don't know which versions you use to generate.

@tmc
Copy link
Owner

tmc commented Jan 1, 2022

@dnovikoff thanks for pointing this out -- I'm happy to accept a modernization of the codegen here to use buf to make the output more stable -- is that something you'd be open to helping with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants