Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit docker restarting when no configuration change #92

Merged
merged 2 commits into from
Nov 30, 2014

Conversation

otahi
Copy link
Collaborator

@otahi otahi commented Nov 23, 2014

I have changed to inhibit docker restarting when no configuration change to make docker containers alive as many as possible. This change is related to #85, but this can only solve a part of the issue.

I have tested with a Vagrantfile. The test result is OK(I avoided CentOS 6.5 because docker does not work with newest package).

[otahi@otahiair vagrant-proxyconf-test]$ for vm in centos7 ubuntu14.04 boot2docker ; do echo -n $vm, ; vagrant ssh $vm -c 'sudo
 cat /proc/`pgrep docker|head -n1`/environ | grep -c http_proxy' 2&> /dev/null ; done
centos7,1
ubuntu14.04,1
boot2docker,1
[otahi@otahiair vagrant-proxyconf-test]$

@otahi
Copy link
Collaborator Author

otahi commented Nov 30, 2014

@tmatilai,
What do you think this?

@tmatilai tmatilai merged commit 041dd49 into tmatilai:master Nov 30, 2014
tmatilai added a commit that referenced this pull request Nov 30, 2014
Inhibit docker restarting when no configuration change

Conflicts:
	lib/vagrant-proxyconf/action/configure_docker_proxy.rb
	lib/vagrant-proxyconf/cap/coreos/docker_proxy_conf.rb
@tmatilai
Copy link
Owner

I'll trust this is good. =)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants