Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Plottable class #50

Open
tmancal74 opened this issue Oct 24, 2017 · 2 comments
Open

Implement Plottable class #50

tmancal74 opened this issue Oct 24, 2017 · 2 comments
Assignees
Milestone

Comments

@tmancal74
Copy link
Owner

Use it in DFunction, CorrelationFunction, SpectralDensity and AbsSpectrum and other classes to control plotting.

@tmancal74 tmancal74 added this to the Release 0.1 milestone Oct 25, 2017
@tmancal74
Copy link
Owner Author

It seems to me to make more sense to implement a Plotter object that would be able to plot the objects occurring in Quantarhei, rather than implement plotting methods in individual classes.

Advantages:

  1. the classes would not contain a difficult-to-test code (which the plotting part always is). All Matplotlib code would be concentrated into one class or subpackage.
  2. One can remove the dependency of Quantarhei on Matplotlib (one dependence less is good)
  3. In principle, this could also be an independent package.

@tmancal74
Copy link
Owner Author

I leave the issue open for now, but soon I will create a new issue to get rid of the Matplotlib dependency. I will also create a new project (something like QrheiPlotter, or QPlotter)

@tmancal74 tmancal74 self-assigned this Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant