-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
Adds compatibility for PIXI v5 as PIXI.BaseTexture.realWidth and PIXI.BaseTexture.realHeight are now getters (read-only).
It seems that build succeeded, then some test fails
It looks like PIXI5 now use WebGL and drop canvas2d by default. Do you have any idea to resolve this? |
Some test environments do not have WebGL support. Should be a case of switching over unit tests to rely and use pixi-legacy.js rather than pixi.js |
Is it OK to switch from pixi.js to pixi.js-legacy ? |
The only reason it exists as a dev dependency is for the unit tests, I believe, so I think it'll be fine to switch. |
You probably want to update this line too pixi-multistyle-text/.happo.js Line 14 in 336bed0
|
cc @blurymind Mind taking a look as well? I think you want to keep v4 compatibility for a bit until Gdevelop moves to v5? We can also decide to only support v5 going forward and release a major version. |
OK, now CI is green. |
Feel free to upgrade it 😁 once GD moves to pixi5, we will move to the
upgraded version too. This PR will help us do that without much work. We are currently bundling the minified library with the extension, so this PR will not affect GDevelop
…On Thu, Jan 16, 2020, 11:05 PM TATSUNO Yasuhiro ***@***.***> wrote:
OK, now CI is green.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88?email_source=notifications&email_token=ABRRWVPOIL24SBO6IOGCEWDQ6DR4FA5CNFSM4KHT57KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJF3YRQ#issuecomment-575388742>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRRWVNIFRJHWIF6GQCCDELQ6DR4FANCNFSM4KHT57KA>
.
|
Hi guys, can you please push this version to npm? |
I'm going to merge it and release a version. What's going to happen to Pixi with canvas support? Are they dropping it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit! Thank you @exoego
@4ian the pixi-multistyle library now supports pixi5, so it wont be a problem when updating GD to 5 :) |
Great! We should get started with the migration to Pixi 5 on GDevelop then :) |
Will there be support for bitmapText from pixi v5 ? |
Closes #83
I took over PR #79 by @motla, because I really need PIXI5 support.