Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm-query: add page #8445

Merged
merged 2 commits into from
Sep 24, 2022
Merged

npm-query: add page #8445

merged 2 commits into from
Sep 24, 2022

Conversation

navarroaxel
Copy link
Collaborator

@navarroaxel navarroaxel commented Sep 2, 2022

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 8.18.0

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Sep 2, 2022
pages/common/npm-query.md Outdated Show resolved Hide resolved

- Find all dependencies with postinstall scripts and uninstall them:

`npm query ":attr(scripts, [postinstall])" | jq 'map(.name) | join("\n")' -r | xargs -I {} npm uninstall {}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a little too specific?

It seems to be more of a tutorial than a basic usage of a command.

Copy link
Member

@SethFalco SethFalco Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm… I think tldr usually consists of common use-cases, not necessarily basic use-cases.
With that in mind, if this is considered a common use-case, I don't see why not.

I've never used npm query actually, so I can't speak for if it's common, but on the surface I see nothing wrong with it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the npm's man page has this use case because the controversial of scripts with postinstall and the associated security risk.

pages/common/npm-query.md Outdated Show resolved Hide resolved
pages/common/npm-query.md Show resolved Hide resolved
@kbdharun kbdharun merged commit d7c8528 into main Sep 24, 2022
@kbdharun kbdharun deleted the pages/npm-query branch September 24, 2022 09:25
@Managor Managor mentioned this pull request Oct 5, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants