-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cur: add page #6133
aws-cur: add page #6133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@258204 Thank you for your contribution.
I have a few review comments.
Co-authored-by: Muhammad Falak R Wani <[email protected]>
Co-authored-by: Muhammad Falak R Wani <[email protected]>
Co-authored-by: Muhammad Falak R Wani <[email protected]>
Thank you for catching those errors. The changes were applied, but something weird happened and your change requests are still listed as open. |
|
||
- Create an AWS cost and usage report definition from a JSON file: | ||
|
||
`aws cur put-report-definition --report-definition file://{{path/to/report-definition.json}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use the samba URI too smb://path/to...
so:
`aws cur put-report-definition --report-definition file://{{path/to/report-definition.json}}` | |
`aws cur put-report-definition --report-definition {{file://path/to/report-definition.json}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried using smb on a machine with samba installed and it didn't work. Have you tried using that notation with this command? Can you share the details so I can replicate it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navarroaxel I'm not so sure about your suggestion. If you have to use file://
every time, it's not really a variable. It's the same with quotes, where we also use "{{text}}"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bl-ue and I haven't been able to get smb://path/to...
to work with aws. At this point I don't think it is compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smb:
has a different syntax anyway, smb://<host>/<path>
(I believe)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, if smb://
doesn't work this is ok then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll spend some more time experimenting with smb and see if I can find a usage that will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it becomes too much work, forget it @285204, because it's likely that only a very few persons will even read this, let alone try it out for real.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a little bit more and convinced myself it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a no-go then. Let's not document it.
Co-authored-by: marchersimon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @258204!
Merging, since this has been open a while and @mfrw's comments appear to have been addressed. |
common/
,linux/
, etc.)For: #5653