Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm-version: add page #14478

Merged
merged 2 commits into from
Oct 30, 2024
Merged

npm-version: add page #14478

merged 2 commits into from
Oct 30, 2024

Conversation

martinblume
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):10.9.0

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 30, 2024
Waples
Waples approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Waples Waples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't think this needs to be documented, except for the major/patch stuff.

@martinblume martinblume force-pushed the feature/npm-version-page branch from 785ebf0 to 5dfe480 Compare October 30, 2024 19:07
spageektti
spageektti approved these changes Oct 30, 2024
View reviewed changes
pages/common/npm-version.md Outdated Show resolved Hide resolved
@spageektti
Copy link
Member

Thanks for your contribution

@martinblume @spageektti
Change argument styling
b6cb26b 
Co-authored-by: Wiktor Perskawiec <[email protected]>
@spageektti spageektti merged commit 9b30d1d into tldr-pages:main Oct 30, 2024
4 checks passed
@martinblume martinblume mentioned this pull request Oct 30, 2024
Open
67 tasks
@martinblume martinblume deleted the feature/npm-version-page branch October 30, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti approved these changes

@Waples Waples Waples approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinblume @spageektti @Waples