Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collaborator: @marchersimon #5390

Closed
bl-ue opened this issue Mar 9, 2021 · 10 comments · Fixed by #5394
Closed

Add collaborator: @marchersimon #5390

bl-ue opened this issue Mar 9, 2021 · 10 comments · Fixed by #5394
Labels
community Issues/PRs dealing with role changes and community organization.

Comments

@bl-ue
Copy link
Contributor

bl-ue commented Mar 9, 2021

Hi, @marchersimon! You seem to be enjoying contributing to the tldr-pages project.
You now have had five distinct pull requests merged (#5368, #5362, #5361, #5357, #5315, #5305, #5294, #5286, and #5282)!
That qualifies you to become a collaborator in this repository, as explained in our community roles documentation.

As a collaborator, you will have commit access to the repository.
That means you can merge pull requests, label and close issues, and perform various other maintenance tasks that are needed here and there.
Of course, all of this is voluntary — you're welcome to contribute to the project in whatever ways suit your liking.

If you do decide to start performing maintenance tasks, though, we only ask you to get familiar with the maintainer's guide.

So, what do you say? Can we add you as a collaborator?

Either way, thanks for all your work so far!

@bl-ue bl-ue added the community Issues/PRs dealing with role changes and community organization. label Mar 9, 2021
@marchersimon
Copy link
Collaborator

I didn't expect that so soon 😅. But hell yeah, I'm in.

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 9, 2021

Yesterday we discussed raising the minimum PR count for adding new collaborators from 5 to 10, but you already have 9 merged, and you added 2 more, so I think it's fine. 🙂

@sbrl invite?

@sbrl
Copy link
Member

sbrl commented Mar 9, 2021

Invite sent, @marchersimon! Always a pleasure welcoming someone new onboard 🎆

We have a community roles document that describes how we grant roles to people :-)

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 9, 2021

@marchersimon I see that you've accepted the invitation and that you're already wielding your new powers! Be careful though, don't merge more complicated PRs until you've got more experience because we generally have unspoken customs, etc. 😄

Anyway, now that you've accepted, would you like to open a PR adding yourself to MAINTAINERS.md?

@marchersimon
Copy link
Collaborator

Sure, thanks for the info.
I've just looked trough some older PRs and saw that there are many unmerged ones, altough they have enough approvals. Is there a reason for that?

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 9, 2021

Maybe, maybe not. I'd recommend pinging those PRs 👍🏻

@marchersimon
Copy link
Collaborator

What do you mean by pinging? Re-requesting reviews?

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 9, 2021

Sure, or just leave a comment asking what's up, etc.

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 9, 2021

Also @marchersimon, how about you join our Gitter channel, where we can communicate on these subjects a bit better?

@bl-ue
Copy link
Contributor Author

bl-ue commented Mar 10, 2021

Again, welcome @marchersimon!

@bl-ue bl-ue closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants