-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collaborator: @marchersimon #5390
Comments
I didn't expect that so soon 😅. But hell yeah, I'm in. |
Yesterday we discussed raising the minimum PR count for adding new collaborators from 5 to 10, but you already have 9 merged, and you added 2 more, so I think it's fine. 🙂 @sbrl invite? |
Invite sent, @marchersimon! Always a pleasure welcoming someone new onboard 🎆 We have a community roles document that describes how we grant roles to people :-) |
@marchersimon I see that you've accepted the invitation and that you're already wielding your new powers! Be careful though, don't merge more complicated PRs until you've got more experience because we generally have unspoken customs, etc. 😄 Anyway, now that you've accepted, would you like to open a PR adding yourself to |
Sure, thanks for the info. |
Maybe, maybe not. I'd recommend pinging those PRs 👍🏻 |
What do you mean by pinging? Re-requesting reviews? |
Sure, or just leave a comment asking what's up, etc. |
Also @marchersimon, how about you join our Gitter channel, where we can communicate on these subjects a bit better? |
Again, welcome @marchersimon! |
Hi, @marchersimon! You seem to be enjoying contributing to the tldr-pages project.
You now have had five distinct pull requests merged (#5368, #5362, #5361, #5357, #5315, #5305, #5294, #5286, and #5282)!
That qualifies you to become a collaborator in this repository, as explained in our community roles documentation.
As a collaborator, you will have commit access to the repository.
That means you can merge pull requests, label and close issues, and perform various other maintenance tasks that are needed here and there.
Of course, all of this is voluntary — you're welcome to contribute to the project in whatever ways suit your liking.
If you do decide to start performing maintenance tasks, though, we only ask you to get familiar with the maintainer's guide.
So, what do you say? Can we add you as a collaborator?
Either way, thanks for all your work so far!
The text was updated successfully, but these errors were encountered: