Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: enforce 2FA requirement for Org members and collaborators #12209

Closed
kbdharun opened this issue Feb 7, 2024 · 12 comments · Fixed by #12557
Closed

Proposal: enforce 2FA requirement for Org members and collaborators #12209

kbdharun opened this issue Feb 7, 2024 · 12 comments · Fixed by #12557
Labels
archive Archive of changes made in tldr-pages, etc. community Issues/PRs dealing with role changes and community organization. decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. security Issues/PRs related to security.

Comments

@kbdharun
Copy link
Member

kbdharun commented Feb 7, 2024

Continuing #11918 (comment). (cc @sbrl)

I want to propose enabling two-factor authentication (2FA) at an organisational level for all members and outside collaborators to have better operational security (OPSEC) at tldr. This would prevent unauthorized access to the repositories and clients at Org in case the maintainer's credentials are leaked/their device is compromised.

Since we are a decentralized organization, it is essential to implement basic OPSEC practices like 2FA, private vulnerability reporting, etc. We already have some practices in place, 2FA would be the recent addition to it, GitHub is actively requiring accounts to enable 2FA, so you would want to enable it nonetheless.

The following users don't have 2FA enabled for your account, I would like to request you guys to enable it soon (to prevent being automatically removed when enabling the setting in future).

Org Members: @isaacvicente (Enabled 2FA)
Outside Collaborators:


You can enable two-factor authentication here -> https://github.com/settings/security


Reference links/settings

https://github.com/organizations/tldr-pages/settings/security

image

  1. https://github.com/orgs/tldr-pages/outside-collaborators?query=two-factor%3Adisabled
  2. https://github.com/orgs/tldr-pages/people?query=two-factor%3Adisabled
@kbdharun kbdharun added decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. community Issues/PRs dealing with role changes and community organization. archive Archive of changes made in tldr-pages, etc. labels Feb 7, 2024
@CairnThePerson
Copy link
Collaborator

Re-enabled 2FA. Thanks for the notification.

@Managor
Copy link
Collaborator

Managor commented Feb 7, 2024

Enabled.

@sbrl
Copy link
Member

sbrl commented Feb 7, 2024

I definitely support this, as soon as everyone has it enabled. We haven't had a breach (that I know of) yet, but we can never be too careful.

We could consider what to do for people who don't reply on a case-by-case basis e.g. after 1 month.

@patricedenis
Copy link
Collaborator

Hi every one.
I haven't got much time to contribute right now but I enabled the functionality to stay with you guys.
Cheers !

@rubenvereecken
Copy link
Contributor

Feel free to drop me :)

@MrMw3
Copy link
Collaborator

MrMw3 commented Feb 21, 2024

Enabled.

@kbdharun
Copy link
Member Author

kbdharun commented Mar 11, 2024

Update: It's been a month and only 2 more people are yet to respond, I will try contacting @isaacvicente and @quantumflo regarding this through other channels, we can enable this setting after a few more days.

Edit (11/03/24): Sent a mail to @quantumflo informing them about this.

@isaacvicente
Copy link
Member

I'm sorry, I had some exams in my college this week, so I haven't checked anything from Github. I've enabled 2FA now.

@kbdharun
Copy link
Member Author

kbdharun commented Mar 16, 2024

We could consider what to do for people who don't reply on a case-by-case basis e.g. after 1 month.

@sbrl only one more person (@quantumflo) is yet to respond (I sent an email and tried contacting them through other means a few days ago but to no avail). IG we can enable this setting (and update MAINTAINERS.md). We can always reinvite them back when they respond in future. What do you think about this?

@MrMw3
Copy link
Collaborator

MrMw3 commented Mar 17, 2024

@kbdharun
I agree with you.

@kbdharun
Copy link
Member Author

kbdharun commented Mar 20, 2024

Almost enabled the setting where I noticed a new name which didn't appear in both the lists (under the query but just normally), no idea why (their 2FA status was marked with a clock so I suspect they recently disabled it). @Geipro (previously @Proscream) can you enable 2FA for your account?

image

Will wait till this weekend to enable this fully and update the MAINTAINERS.md file.

@kbdharun
Copy link
Member Author

Update: I have enabled the setting now and the 3 collaborators have been removed (will update MAINTAINERS.md to reflect the same and close this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive Archive of changes made in tldr-pages, etc. community Issues/PRs dealing with role changes and community organization. decision A (possibly breaking) decision regarding tldr-pages content, structure, infrastructure, etc. security Issues/PRs related to security.
Projects
Development

Successfully merging a pull request may close this issue.

8 participants