Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results for SteamGridDB are missing #249

Closed
Lucki opened this issue Jun 15, 2019 · 7 comments
Closed

Search results for SteamGridDB are missing #249

Lucki opened this issue Jun 15, 2019 · 7 comments

Comments

@Lucki
Copy link
Contributor

Lucki commented Jun 15, 2019

Expected behavior

Grid images from SteamGridDB are shown as well as JinxSGVI results.

Actual behavior

Only JinxSGVI results are shown if there are any.

Steps to reproduce

Click in any games settings dialog on the download button next to the image-url entry field.
Let's take a popular one for testing: Diablo III
grafik

Version and environment
Version: 0.14.0-164e55c-makepkg
Branch:  makepkg
Commit:  164e55c (164e55c87614657b6a9345b919cefc844a44bf53)
Distro:  Arch Linux
DE:      GNOME
Bonus feature request:

Bring back the clickable links to quickly adjust the search or try further if the search result for that service is missing. (steamgriddbs main page, jinxsgvi since it's very picky about the name, and the google search was useful in the past too)

@tkashkin
Copy link
Owner

GET https://steamgriddb.com/api/v2/search/autocomplete/<anything>:

{
	"success": false,
	"errors": ["Authentication Required"]
}

It seems SteamGridDB suddenly started to require authentication. There were nothing about API keys a few days ago when I was implementing this 😕.

tkashkin added a commit that referenced this issue Jun 15, 2019
IGDB description visibility settings
@tkashkin
Copy link
Owner

It should be fixed.

Bring back the clickable links

Links are readded.

jinxsgvi since it's very picky about the name

You can change game name in preferences dialog and reopen popup. It should search for images with new name. (SteamGridDB doesn't use name for Steam games and searches by appid)

@Lucki
Copy link
Contributor Author

Lucki commented Jun 15, 2019

That's great!
I've noticed the top of the popup gets cut off from the window on small settings pages (usually on games provided by steam):
grafik

@tkashkin
Copy link
Owner

@Lucki

popup gets cut off

It should be fixed, let me know if not.

@Lucki
Copy link
Contributor Author

Lucki commented Jun 16, 2019

@tkashkin I'm sorry but now it's cut off at the bottom.
grafik

tkashkin added a commit that referenced this issue Jun 20, 2019
Improved image scaling
Fix images downloader popup being cut off in some cases (#249)
@tkashkin
Copy link
Owner

@Lucki now it should be fixed.

@Lucki
Copy link
Contributor Author

Lucki commented Jun 22, 2019

It is!

Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
IGDB description visibility settings


Former-commit-id: 530e231
Lucki pushed a commit to Lucki/GameHub that referenced this issue Oct 30, 2021
Improved image scaling
Fix images downloader popup being cut off in some cases (tkashkin#249)


Former-commit-id: 1543581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants