Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit language for codeblock highlighting #9

Closed
vemonet opened this issue Mar 14, 2024 · 3 comments
Closed

Edit language for codeblock highlighting #9

vemonet opened this issue Mar 14, 2024 · 3 comments

Comments

@vemonet
Copy link

vemonet commented Mar 14, 2024

Currently Marker does not seems to support editing language for codeblock highlights e.g.

```python
import os
```

Would be nice to have this!

@vemonet vemonet changed the title Language for code highlighting Edit language for codeblock highlighting Mar 14, 2024
@tk04
Copy link
Owner

tk04 commented Mar 14, 2024

The app supports syntax highlighting for code blocks (with language identifiers). Could you clarify more on what you're talking about?

@vemonet
Copy link
Author

vemonet commented Mar 14, 2024

In the editor, I cannot change the language of an existing codeblock, I cannot even see which language is defined for this codeblock

But, indeed creating a new codeblock with a specific language works well

Ideally I would expect that when clicking inside a codeblock there would be a little popup at the bottom right or top right of the codeblock with a text field that shows the language (and autocomplete based on all available languages ideally!). A bit like you have done for Links

Note I am using Ubuntu 22.04 with xorg display (in case that might be a bug)

Really cool implementation btw! Clean code and user-friendly interface, there are not a lot of good markdown editor out there. And this new one might be the best one! Typora is really good but closed source, and Marktext/Muya is ok, but the underlying JS code seems quite messy. Using tiptap for the editor looks really good and fitting the need

@tk04
Copy link
Owner

tk04 commented Mar 17, 2024

Thanks for the feedback, added this in v1.0.1.

@tk04 tk04 closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants