Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd delete-tag assumes "origin" as remote for tags #870

Closed
elonderin opened this issue Sep 8, 2020 · 3 comments · Fixed by #889
Closed

cmd delete-tag assumes "origin" as remote for tags #870

elonderin opened this issue Sep 8, 2020 · 3 comments · Fixed by #889

Comments

@elonderin
Copy link
Contributor

elonderin commented Sep 8, 2020

delete-tag the pushes the against the hard-coded remote 'origin' .

This failed for me b/c i renamed this usually to 'o' for laziness' sake ;)

delete branch figures the remote out from the branche's remote which doens't work for tags.
However, the current branch's remote could be used as a fall back which to me would make sense in most cases.

Another idea were to make the remote a CLI option or could be even put into the git config.
Note sure if this issue comes up in other extra commands as well in which case a consistent behavior across all commands would be appreciated

@spacewander
Copy link
Collaborator

We can store the default remote as git config git-extras.default_remote. PR is welcome!

@vanpipy
Copy link
Collaborator

vanpipy commented Nov 7, 2020

A default remote is better. And I think a situation like git-delete-tag --origin someRemote tagName or git-delete-tag tagName with git-extras.remote.

I think to try to give a parameter will be more comfortable.

But more parameters makes the git-delete-tag complex..:D

@vanpipy
Copy link
Collaborator

vanpipy commented Nov 8, 2020

Follow the PR, I dont think to set a default remote is the best choice to take the laziness convenience.

The default remote is hard to explain bases on git-extras. On the other side, the git-delete-tag tagName tagName tagName --origin remoteName will be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants