Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want an updated Makefile for BSD/Homebrew/non-root? #463

Open
apjanke opened this issue Oct 3, 2015 · 8 comments
Open

Want an updated Makefile for BSD/Homebrew/non-root? #463

apjanke opened this issue Oct 3, 2015 · 8 comments

Comments

@apjanke
Copy link
Contributor

apjanke commented Oct 3, 2015

Hi folks,

I've just discovered git-extras through my work with Oh My Zsh and Homebrew and I'm digging it; I'd like to start using it regularly. I'm mainly an OS X/Homebrew user with a multi-user, multi-machine setup, and I'm running in to a few issues on this platform. I've got space for a weekend project. Would you be interested in a PR(s) that updated the Makefile and build process to do some or all of:

  • Make sure the whole build, including doco generation, works under BSD/OS X
  • Support relocating etc (make install fails for different install locations of bash_completion #237)
  • Support disabling selected commands and suppressing prompting for alias conflicts (Is possible to disable some commands? #442, Install only some commands? #228)
    • (would make fully unattended, repeatable installs possible)
    • Remove man & doco for disabled commands, just to be tidy
  • Split the build and install into two steps, so you could build the commands (slurping in the library files) and run them inside the local source tree without having to install to the final destination (useful for iterating development)
  • Install the HTML and other format docs under /usr/share/doc (right now it looks like they're going under man, which should really only be for man-formatted stuff)
  • Unify makefile.msys with the main Makefile (Is makefile.msys duplicate? #427)

Regardless, cheers for the good work.

@spacewander
Copy link
Collaborator

Waiting for it 😄

@qw3rtman
Copy link
Collaborator

My only concern is that the build and install into two steps should be opt-in and not opt-out, so that the installation process doesn't become more complicated.

Otherwise, looking forward to seeing a PR from you. Thanks! 👍

@apjanke
Copy link
Contributor Author

apjanke commented Oct 18, 2015

Yeah, it'll be opt-in and transparent to users: make install will do the same thing as it does now, and do the build step internally as a dependency. This will just give developers the option to request just a local build with a make build or similar command.

@qw3rtman
Copy link
Collaborator

Sounds like a good idea to me! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@qw3rtman @apjanke @spacewander and others