From 9916356b142dc2d34992b03784afe818afe668da Mon Sep 17 00:00:00 2001
From: spacewander <spacewanderlzx@gmail.com>
Date: Sat, 12 Sep 2015 18:44:48 +0800
Subject: [PATCH] add alias conflict prompt

---
 Makefile | 32 ++++++++++++++++++++++++--------
 1 file changed, 24 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index ae4c71d43..6c2d2870e 100644
--- a/Makefile
+++ b/Makefile
@@ -23,17 +23,33 @@ install:
 	$(eval TEMPFILE := $(shell mktemp -q ${TMPDIR:-/tmp}/git-extras.XXXXXX 2>/dev/null || mktemp -q))
 	@# chmod from rw-------(default) to rwxrwxr-x, so that users can exec the scripts
 	@chmod 775 $(TEMPFILE)
+	$(eval EXISTED_ALIASES := $(shell \
+		git config --get-regexp 'alias.*' | awk '{print "git-" substr($$1, 7)}'))
 	@$(foreach COMMAND, $(COMMANDS_USED_WITH_GIT_REPO), \
-		echo "... installing $(COMMAND)"; \
-		head -1 bin/$(COMMAND) | cat - $(LIB) ./helper/is-git-repo > $(TEMPFILE); \
-		tail -n +2 bin/$(COMMAND) >> $(TEMPFILE); \
-		cp -f $(TEMPFILE) $(DESTDIR)$(BINPREFIX)/$(COMMAND); \
+		disable=''; \
+		if test ! -z "$(filter $(COMMAND), $(EXISTED_ALIASES))"; then \
+			read -p "$(COMMAND) conflicts with an alias, still install it and disable the alias? [y/n]" answer; \
+			test "$$answer" = 'n' -o "$$answer" = 'N' && disable="true"; \
+		fi; \
+		if test -z "$$disable"; then \
+			echo "... installing $(COMMAND)"; \
+			head -1 bin/$(COMMAND) | cat - $(LIB) ./helper/is-git-repo > $(TEMPFILE); \
+			tail -n +2 bin/$(COMMAND) >> $(TEMPFILE); \
+			cp -f $(TEMPFILE) $(DESTDIR)$(BINPREFIX)/$(COMMAND); \
+		fi; \
 	)
 	@$(foreach COMMAND, $(COMMANDS_USED_WITHOUT_GIT_REPO), \
-		echo "... installing $(COMMAND)"; \
-		head -1 bin/$(COMMAND) | cat - $(LIB) > $(TEMPFILE); \
-		tail -n +2 bin/$(COMMAND) >> $(TEMPFILE); \
-		cp -f $(TEMPFILE) $(DESTDIR)$(BINPREFIX)/$(COMMAND); \
+		disable=''; \
+		if test ! -z "$(filter $(COMMAND), $(EXISTED_ALIASES))"; then \
+			read -p "$(COMMAND) conflicts with an alias, still install it and disable the alias? [y/n]" answer; \
+			test "$$answer" = 'n' -o "$$answer" = 'N' && disable="true"; \
+		fi; \
+		if test -z "$$disable"; then \
+			echo "... installing $(COMMAND)"; \
+			head -1 bin/$(COMMAND) | cat - $(LIB) > $(TEMPFILE); \
+			tail -n +2 bin/$(COMMAND) >> $(TEMPFILE); \
+			cp -f $(TEMPFILE) $(DESTDIR)$(BINPREFIX)/$(COMMAND); \
+		fi; \
 	)
 	@if [ -z "$(wildcard man/git-*.1)" ]; then \
 		echo "WARNING: man pages not created, use 'make docs' (which requires 'ronn' ruby lib)"; \