-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option.implies() #1724
Add Option.implies() #1724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have added extra code to support separate treatment of positive and negative dual options based on the stored option values. (In future, this might be used to expand the |
Marked for re-review after the additions. (Thanks for initial review too.) |
Back to draft. Improving examples, and looking into interaction with |
Sorted again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Pull Request
Problem
See: #1358
Solution
Add support for supplying a hash of implied option values. Add implementation support to have separate implied options for positive and negative dual options.
Details:
Side notes:
console
for code blocks with mixed commands and output for nicer display in READMEsh
rather thanbash
for code blocks which don't show outputChangeLog
Option.implies()
to set other option values when the option is specified