Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for "global" options #1708

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Mar 20, 2022

Pull Request

Problem

Sometimes people would like to be able to add common (global) options to all the subcommands, rather than to the program. This was the most popular enhancement in poll #1551 (comment)

Related:

I tried adding an explicit routine in #1670 but it turned out less effective than leaving it up to the user.

Solution

Add an example file showing two ways to add global options to subcommands.

@shadowspawn shadowspawn changed the title Add example for common-options Add example for "global" options Mar 20, 2022
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn merged commit 40e67bc into tj:develop Mar 21, 2022
@shadowspawn shadowspawn deleted the feature/common-options-example branch March 21, 2022 02:05
@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Mar 21, 2022
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Apr 15, 2022
mfranzke added a commit to mfranzke/patternlab-node that referenced this pull request Jan 4, 2023
JosefBredereck added a commit to pattern-lab/patternlab-node that referenced this pull request Jan 7, 2023
* refactor: updated dependency commander

* fix: downgraded the major version update of commander again

* refactor: updated dependency commander

* refactor: updated dependency commander

* refactor: updated dependency commander

* refactor: updated dependency commander

* refactor: updated dependency commander

* build: regenerated yarn.lock

* refactor: adapted "global" options example

tj/commander.js#1708

* refactor: updated to the latest version

Co-authored-by: Josef Bredreck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants