Deprecate command:* command and event #1612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The command events are an original implementation detail which has changed. They have been shown in the README to supply some missing functionality, so we keep them working.
The
.command('*')
and.on('command:*')
events in particular are no longer needed as there are newer more explicit ways of doing what they were used for.This PR prompt by confusion in: #1609
I have not tracked down the commits that removed them, but back in v4 the README had these two code fragments:
Solution
Remove from README and add to deprecated.
ChangeLog
.command('*')
on('command:*')