Add parent command as prefix of subcommand #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix multiple parent order (although multiple levels not yet supported) - without using any new javascript features
shadowspawn
changed the title
|
Looking for a review before merging from anyone who looked at original PR: @abetomo @simonbuchan @mojavelinux |
simonbuchan
approved these changes
Jun 24, 2019
| .name('test') | ||
| .command('info [options]') | ||
|
|
||
| program.commands[0].helpInformation().should.startWith('Usage: test info [options]') |
There was a problem hiding this comment.
Would be nice to have a nested command test too, if that's explicitly being handled.
There was a problem hiding this comment.
Nested commands are not currently supported! But since the code included a loop, I thought it should do it right for the possible future. :-)
| var usage = [ | ||
| 'Usage: ' + cmdName + ' ' + this.usage(), | ||
| 'Usage: ' + parentCmdNames + cmdName + ' ' + this.usage(), |
There was a problem hiding this comment.
Tiny nit, you can shorten this by having the loop above mutate cmdName instead of , since it's not used below.
There was a problem hiding this comment.
Thanks. I did wonder about that too, but went for long and clear.
|
Thanks @abetomo and @simonbuchan |
shadowspawn
added a commit
that referenced
this pull request
Jun 24, 2019
shadowspawn
added
the
pending release
|
Available now as a prerelease. See #1001 |
shadowspawn
removed
the
pending release
This was referenced Oct 11, 2019
This was referenced Oct 18, 2019
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor rework of #740 to add parent commands into usage help for subcommands:
Resolves #739