fix(ts): action can be an async function

Since we can use `parseAsync` for async functions so the action can be asynchronous. related to #806
tj · Jan 30, 2020 · 72062a5 · 72062a5
1 parent d9627f5
commit 72062a5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/typings/commander-tests.ts b/typings/commander-tests.ts
@@ -45,6 +45,14 @@ function increaseVerbosity(v: any, total: number) {
     return total + 1;
 }
 
+function syncCall() {
+    console.log("Sync success!");
+}
+
+async function asyncCall() {
+    return;
+}
+
 program
     .version('0.0.1')
     .usage('[options] <file ...>')
@@ -112,6 +120,8 @@ program
 program
     .command("name1", "description")
     .command("name2", "description", { isDefault:true })
+    .command("name3", "description").action(syncCall)
+    .command("name4", "description").action(asyncCall)
 
 program
     .exitOverride();

diff --git a/typings/index.d.ts b/typings/index.d.ts
@@ -115,7 +115,7 @@ declare namespace commander {
      *
      * @returns Command for chaining
      */
-    action(fn: (...args: any[]) => void): Command;
+    action(fn: (...args: any[]) => void | Promise<void>): Command;
 
     /**
      * Define option with `flags`, `description` and optional