Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teaching loading via Groovy scripting #14

Open
tischi opened this issue Nov 25, 2020 · 9 comments
Open

Teaching loading via Groovy scripting #14

tischi opened this issue Nov 25, 2020 · 9 comments

Comments

@tischi
Copy link
Owner

tischi commented Nov 25, 2020

@joshmoore (cc @constantinpape)

Here's the current Java code:

OMEZarrS3Reader reader = new OMEZarrS3Reader( "https://s3.embl.de", "us-west-2", "i2k-2020" );
SpimData em = reader.readSpimData( "em-raw.ome.zarr" );
BdvFunctions.show( em );

leading to below result 🥳

image

I think that's actually quite nice and we could show this in the workshop, what do you think?

@tischi
Copy link
Owner Author

tischi commented Nov 25, 2020

Hi @will-moore, adding you to the thread.

@joshmoore
Copy link
Collaborator

Very nice!

@tischi
Copy link
Owner Author

tischi commented Nov 25, 2020

Are you 100% happy with the API? Like the names of the class and so on? I am happy to change it!

OMEZarrS3Reader reader = new OMEZarrS3Reader( "https://s3.embl.de", "us-west-2", "i2k-2020" );
SpimData em = reader.readSpimData( "em-raw.ome.zarr" );

If possible it would be nice if that could stay like this after we've shown it on I2K.

@joshmoore
Copy link
Collaborator

joshmoore commented Nov 25, 2020

I don't think I could do better than that at this point, though I admittedly don't know much about the naming of other readers in BDV space. ("SpimData" is more of a concern more me, but that was already discussed with Tobias long ago in Dresden.)

@tischi
Copy link
Owner Author

tischi commented Nov 26, 2020

"SpimData" is more of a concern more me, but that was already discussed with Tobias long ago in Dresden

I agree, see the discussion that I just started in gitter (bdv-core).
I would like to push for and I think I could manage until the workshop.

OMEZarrS3Reader reader = new OMEZarrS3Reader( "https://s3.embl.de", "us-west-2", "i2k-2020" );
List< SourceAndConverter > images = reader.read( "em-raw.ome.zarr" );
BdvFunctions.show( images.get( 0 ) );

@joshmoore
Copy link
Collaborator

@tischi
Copy link
Owner Author

tischi commented Nov 26, 2020

@joshmoore @constantinpape @will-moore

I just had a phone call with @NicoKiaru about this. I work with Nico on bdv-playground, where one of the main points in fact is to use SourceAndConverter as much as possible, because we think this is the currently best image data model (I would say the equivalent of ImagePlus) in imglib2.

Now, I discussed with Nico and we decided that if we want to show fancy coloured (maybe even interactive) label masks on I2K we should do this via the bdv-playground project.

In addition, I think we should show BdvFunctions.show( SourceAndConverter sac ), because BdvFunctions.show() is still the best entry point for beginners?! @NicoKiaru would you agree or would you prefer some bdv-playground based entry point to show a sac in BDV?

Now, the issue is, if we want to show this cool stuff during I2K we have to ship versions of bdv-playground, bdv-vistools, bdv-core and maybe a bunch of other libraries that are very recent and not compatible with the current Fiji, e.g. they will break BigStitcher.

Question is whether we (a) should implement the new stuff, and tell the people that they should download a special Fiji for this workshop in order not to break their old one or (b) just live with SpimData and black and white label masks but be compatible with the current Fiji?

Opinions?

@NicoKiaru
Copy link

@NicoKiaru would you agree or would you prefer some bdv-playground based entry point to show a sac in BDV?

BdvFunctions.show is definitely the way to go for the tutorial. bdv-playground is not standard enough. Let's try to come up with some cool and compatible stuff in the near future.

@joshmoore
Copy link
Collaborator

I understand little of the above, but it all sounds exciting. 🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants