net: enable native golang linux networking #4498
Conversation
leongross
force-pushed
the
net-linux-nonlinux
branch
7 times, most recently
from
bbd514e to
fdc75d6
Compare
There was a problem hiding this comment.
How did you test this?
To accept this into TinyGo, I'd like to see at least some tests. For example, you can create a new test like testdata/net.go (and add it to main_test.go for Linux only). It doesn't have to be exhaustive, but for example you can start a socket server (net.Listen) in a goroutine and try to connect to it from the same program.
|
@aykevl I will add some basic tests. Since I already did some testing (I hope) it should be fairly easy to integrate this here. |
leongross
force-pushed
the
net-linux-nonlinux
branch
4 times, most recently
from
4ec411d to
e1f18b2
Compare
leongross
force-pushed
the
net-linux-nonlinux
branch
3 times, most recently
from
81fd6ff to
52be3d8
Compare
src/runtime/sync.go
Outdated
| type semTable [semTabSize]struct { | ||
| root semaRoot | ||
| pad [64 - unsafe.Sizeof(semaRoot{})]byte // only 64 x86_64, make this variable | ||
| } | ||
|
|
||
| func (t *semTable) rootFor(addr *uint32) *semaRoot { | ||
| return &t[(uintptr(unsafe.Pointer(addr))>>3)%semTabSize].root | ||
| } |
There was a problem hiding this comment.
Can you explain what this is doing, and what it's for?
src/runtime/sync.go
Outdated
| if cansemacquire(sema) { | ||
| return | ||
| } |
There was a problem hiding this comment.
This doesn't look like a complete implementation?
You need to wait for the other goroutine to do a semrelease. (This would be easy with multithreading and real OS futexes, but they don't exist yet).
Either you can busy loop with Gosched() (terrible idea) or put the waiting goroutine in a hashmap to be awoken by semrelease (slightly less terrible idea).
| panic("todo: runtime_pollServerInit") | ||
| // fmt.Printf("poll_runtime_pollServerInit not implemented, skipping panic\n") |
There was a problem hiding this comment.
If you put in debugging code, please remove it before sending in a PR. It makes the diff bigger and more work to review.
Generally, take a look at the PR diff and see if there's any part of it that is not necessary and can be removed (such as the changes to .gitmodules and the signal changes that are still part of this PR).
(Also, how do you know that you can just remove this panic?)
leongross
force-pushed
the
net-linux-nonlinux
branch
8 times, most recently
from
72cea16 to
182dd87
Compare
leongross
force-pushed
the
net-linux-nonlinux
branch
from
e2e6576 to
1986937
Compare
leongross
force-pushed
the
net-linux-nonlinux
branch
from
1986937 to
5f0f0aa
Compare
leongross
force-pushed
the
net-linux-nonlinux
branch
from
5f0f0aa to
1620b10
Compare
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
if this does not work, do the folliwing steps: 1. remove net submodule 2. remove symlink in local ~/.cache/tinygo/goroot-<hash>/net 3. manual symlink yo local golang /usr/local/bin/src/net Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
net-linux-nonlinux
branch
from
1620b10 to
7529187
Compare
Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
net-linux-nonlinux
branch
from
7529187 to
50b719f
Compare
Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
net-linux-nonlinux
branch
from
50b719f to
c16ff80
Compare
This is a rework of the plain linux network POC #4460. This PR adds adaptive switching of network packages depending on the
GOOS.The CI fails due to unadjusted build tags for MacOs and WASm.
Successfully tested on
linux/amd64.