Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Recognize changes to remote URLs & support revision option #92

Merged
merged 29 commits into from
Jan 14, 2025
Merged

feat: Recognize changes to remote URLs & support revision option #92

merged 29 commits into from
Jan 14, 2025
+848 −47

Conversation

bezhermoso
Copy link
Member

@bezhermoso bezhermoso commented Jan 11, 2025 •
edited
Loading

  • Recognize changes to remote URL
  • Support revision
    • Branch
    • Tag
    • SHA1
  • Atomicity
  • Tests

@bezhermoso bezhermoso requested a review from a team as a code owner January 11, 2025 18:34
@bezhermoso bezhermoso requested review from JamyGolden and removed request for a team January 11, 2025 18:34
JamyGolden
JamyGolden reviewed Jan 12, 2025
View reviewed changes
Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I tested it out and works. Let me know when you've added tests and I'll merge.

Cargo.lock
@@ -1,6 +1,6 @@
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
version = 3
version = 4
Copy link
Member

@JamyGolden JamyGolden Jan 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line change is causing the cargo deny error.

@bezhermoso
Copy link
Member Author

Btw, I'm working on avoiding rev-parse, because it will resolve things like HEAD~, which is wrong. I will make this explicitly only allow branch names, tags, and commit SHA1s.

bezhermoso
bezhermoso commented Jan 13, 2025
View reviewed changes
.github/workflows/lint.yml
@@ -47,6 +47,8 @@ jobs:
- uses: actions-rust-lang/setup-rust-toolchain@v1

- uses: EmbarkStudios/cargo-deny-action@v1
with:
rust-version: "1.84.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamyGolden Looks like cargo-deny-action uses an older Rust version than what setup-rust-toolchain uses for the rest.

@bezhermoso bezhermoso requested a review from JamyGolden January 13, 2025 22:36
JamyGolden
JamyGolden approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@JamyGolden JamyGolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work on this PR. Last thing to add is an entry in the CHANGELOG.md file under ## Unreleased. You can create a ## Changed and or ## Added and just add info in there you think makes sense. I'll merge right after and create a new Release.

@bezhermoso bezhermoso requested a review from JamyGolden January 14, 2025 15:37
@JamyGolden JamyGolden merged commit 5cf3897 into tinted-theming:main Jan 14, 2025
5 checks passed
@bezhermoso bezhermoso mentioned this pull request Jan 14, 2025
Closed
@JamyGolden
Copy link
Member

Just released tiny 0.25.0 so all changes should be included there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamyGolden JamyGolden Awaiting requested review from JamyGolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bezhermoso @JamyGolden