Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): exclude popular hidden directories #3252

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 16, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit cfaad26):

https://taiga-ui--pr3252-splincode-ci-schemat-o06mgm8v.web.app

(expires Sat, 17 Dec 2022 13:12:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Dec 16, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
331KB +10%
demo/browser/vendor.(hash).js
204.86KB +10%
demo/browser/runtime.(hash).js
34.52KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.23MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 61.48% // Head: 61.48% // No change to project coverage 👍

Coverage data is based on head (cfaad26) compared to base (de63d7b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3252   +/-   ##
=======================================
  Coverage   61.48%   61.48%           
=======================================
  Files        1525     1525           
  Lines       18047    18047           
  Branches     2521     2521           
=======================================
  Hits        11096    11096           
  Misses       6494     6494           
  Partials      457      457           
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 48.73% <ø> (ø)
addon-editor 51.23% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.70% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.00% <0.00%> (ø)
core 77.05% <ø> (ø)
kit 73.03% <ø> (ø)
summary 61.48% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/cdk/schematics/constants/file-globs.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin merged commit 6ea575e into main Dec 19, 2022
@vladimirpotekhin vladimirpotekhin deleted the splincode/ci/schematics branch December 19, 2022 08:35
@well-done-bot
Copy link

well-done-bot bot commented Dec 19, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants