Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): TextfieldController add prefix, postfix and filler #3188

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3067

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 7, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Visit the preview URL for this PR (updated for commit 12fe549):

https://taiga-ui--pr3188-textfield-controller-fsh2ylcw.web.app

(expires Fri, 16 Dec 2022 09:25:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Dec 7, 2022

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
329.45KB (+611B +0.18%) +10%
demo/browser/runtime.(hash).js
34.43KB (-24B -0.07%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.86KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +587B +0.1%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (+2.29KB +0.1%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 61.44% // Head: 68.54% // Increases project coverage by +7.10% 🎉

Coverage data is based on head (12fe549) compared to base (29921c8).
Patch coverage: 97.91% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
+ Coverage   61.44%   68.54%   +7.10%     
==========================================
  Files        1516     1123     -393     
  Lines       17944    13556    -4388     
  Branches     2512     1899     -613     
==========================================
- Hits        11025     9292    -1733     
+ Misses       6463     3942    -2521     
+ Partials      456      322     -134     
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 48.73% <ø> (ø)
addon-editor 51.23% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.70% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk ∅ <ø> (∅)
core 77.05% <97.61%> (+0.26%) ⬆️
kit 73.28% <100.00%> (+0.02%) ⬆️
summary 68.54% <97.91%> (+7.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...it/components/input-count/input-count.component.ts 84.14% <ø> (ø)
.../components/input-number/input-number.component.ts 73.73% <ø> (ø)
.../kit/components/input-time/input-time.component.ts 84.61% <ø> (ø)
...textfield-controller/textfield-prefix.directive.ts 85.71% <85.71%> (ø)
...imitive-textfield/primitive-textfield.component.ts 76.82% <100.00%> (+0.87%) ⬆️
...ects/core/directives/textfield-controller/index.ts 100.00% <100.00%> (ø)
...extfield-controller/textfield-controller.module.ts 100.00% <100.00%> (ø)
...tfield-controller/textfield-controller.provider.ts 100.00% <100.00%> (ø)
...textfield-controller/textfield-filler.directive.ts 100.00% <100.00%> (ø)
...extfield-controller/textfield-postfix.directive.ts 100.00% <100.00%> (ø)
... and 400 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin changed the title feat(core): TextfieldController add prefix and postfix [WIP] feat(core): TextfieldController add prefix and postfix Dec 12, 2022
@vladimirpotekhin vladimirpotekhin force-pushed the textfield-controller branch 2 times, most recently from 94a0fd6 to e3fbba6 Compare December 12, 2022 09:41
@vladimirpotekhin vladimirpotekhin changed the title [WIP] feat(core): TextfieldController add prefix and postfix feat(core): TextfieldController add prefix, postfix and filler Dec 12, 2022
@splincode splincode requested a review from nsbarsukov December 13, 2022 10:10
@vladimirpotekhin vladimirpotekhin merged commit 75276fb into main Dec 15, 2022
@vladimirpotekhin vladimirpotekhin deleted the textfield-controller branch December 15, 2022 10:39
@well-done-bot
Copy link

well-done-bot bot commented Dec 15, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Add prefix/postfix to TextfieldController
5 participants