Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): hide autofill button for Safari #3061

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

splincode
Copy link
Member

@splincode splincode commented Nov 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3059

image

image

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 14, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 14, 2022

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
323.57KB (-221B -0.07%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.14KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change -223B -0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (-195B -0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

Visit the preview URL for this PR (updated for commit 36df6f6):

https://taiga-ui--pr3061-splincode-fix-issues-xn2ycsxd.web.app

(expires Wed, 16 Nov 2022 08:45:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:harold_smile:

@splincode splincode force-pushed the splincode/fix/issues/3059 branch from a264886 to 36df6f6 Compare November 15, 2022 08:41
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 61.89% // Head: 61.89% // No change to project coverage 👍

Coverage data is based on head (36df6f6) compared to base (29659b5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3061   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files        1490     1490           
  Lines       17605    17605           
  Branches     2402     2402           
=======================================
  Hits        10897    10897           
  Misses       6268     6268           
  Partials      440      440           
Flag Coverage Δ
addon-charts 72.48% <ø> (ø)
addon-doc 48.40% <ø> (ø)
addon-editor 51.42% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 63.91% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.37% <ø> (ø)
core 76.80% <ø> (ø)
kit 74.25% <ø> (ø)
summary 61.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ics/ng-update/tests/schematic-replace-html.spec.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 27a6aa2 into main Nov 15, 2022
@splincode splincode deleted the splincode/fix/issues/3059 branch November 15, 2022 09:15
@well-done-bot
Copy link

well-done-bot bot commented Nov 15, 2022

'Well done'

splincode added a commit that referenced this pull request Nov 16, 2022
oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Input pseudo elements in Safari
3 participants