Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-commerce): InputExpire fix translation in safari #3043

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

2022-11-09.18.31.16.mov

#3013

What is the new behavior?

2022-11-09.18.30.36.mov

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 9, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 9, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
323.36KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.03KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Visit the preview URL for this PR (updated for commit e676912):

https://taiga-ui--pr3043-safari-translate-fix-o6fzkk8s.web.app

(expires Thu, 10 Nov 2022 14:44:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 0.00% // Head: 67.13% // Increases project coverage by +67.13% 🎉

Coverage data is based on head (e676912) compared to base (c2aac4b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3043       +/-   ##
=========================================
+ Coverage      0   67.13%   +67.13%     
=========================================
  Files         0      768      +768     
  Lines         0     9663     +9663     
  Branches      0     1357     +1357     
=========================================
+ Hits          0     6487     +6487     
- Misses        0     2951     +2951     
- Partials      0      225      +225     
Flag Coverage Δ
addon-charts 86.77% <ø> (?)
addon-doc 48.46% <ø> (?)
addon-editor 51.42% <ø> (?)
addon-mobile 62.31% <ø> (?)
addon-table 64.06% <ø> (?)
addon-tablebars ∅ <ø> (?)
cdk ∅ <ø> (?)
core ∅ <ø> (?)
kit 74.14% <ø> (?)
summary 67.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ects/kit/components/input-tag/input-tag-options.ts 100.00% <0.00%> (ø)
projects/addon-editor/types/index.ts 0.00% <0.00%> (ø)
...t/directives/project-class/project-class.module.ts 100.00% <0.00%> (ø)
...ectives/value-accessor/value-accessor.directive.ts 100.00% <0.00%> (ø)
...ble/components/table/directives/thead.directive.ts 83.33% <0.00%> (ø)
...ts/kit/components/input-tag/input-tag.component.ts 73.41% <0.00%> (ø)
...ts/addon-table/components/table/th/th.component.ts 33.33% <0.00%> (ø)
projects/kit/components/calendar-range/index.ts 100.00% <0.00%> (ø)
.../kit/components/multi-select/hide-selected.pipe.ts 85.71% <0.00%> (ø)
projects/addon-doc/src/languages/russian.ts 100.00% <0.00%> (ø)
... and 758 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin merged commit 1a258c5 into main Nov 10, 2022
@vladimirpotekhin vladimirpotekhin deleted the safari-translate-fix branch November 10, 2022 08:01
@well-done-bot
Copy link

well-done-bot bot commented Nov 10, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants