Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): change underline color for today cell in calendar #3037

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

splincode
Copy link
Member

@splincode splincode commented Nov 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3034
UIKIT-6174

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 9, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 9, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
323.54KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.04KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Visit the preview URL for this PR (updated for commit 84406e1):

https://taiga-ui--pr3037-splincode-feat-issue-o3clro26.web.app

(expires Thu, 10 Nov 2022 08:43:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 0.00% // Head: 68.95% // Increases project coverage by +68.95% 🎉

Coverage data is based on head (84406e1) compared to base (a662b83).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3037       +/-   ##
=========================================
+ Coverage      0   68.95%   +68.95%     
=========================================
  Files         0     1101     +1101     
  Lines         0    13230    +13230     
  Branches      0     1840     +1840     
=========================================
+ Hits          0     9123     +9123     
- Misses        0     3798     +3798     
- Partials      0      309      +309     
Flag Coverage Δ
addon-charts 72.48% <ø> (?)
addon-doc 48.46% <ø> (?)
addon-editor 51.34% <ø> (?)
addon-mobile 62.31% <ø> (?)
addon-table 64.06% <ø> (?)
addon-tablebars 98.07% <ø> (?)
cdk ∅ <ø> (?)
core 76.79% <ø> (?)
kit 74.11% <ø> (?)
summary 68.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/core/components/calendar/index.ts 100.00% <0.00%> (ø)
...mponents/hosted-dropdown/hosted-dropdown.module.ts 100.00% <0.00%> (ø)
...n-editor/extensions/table-cell-background/index.ts 100.00% <0.00%> (ø)
projects/kit/components/input-phone/index.ts 100.00% <0.00%> (ø)
...rojects/core/pipes/format-date/format-date.pipe.ts 60.00% <0.00%> (ø)
projects/addon-editor/directives/index.ts 100.00% <0.00%> (ø)
...cts/addon-mobile/components/sheet/sheet-options.ts 75.00% <0.00%> (ø)
projects/core/components/root/index.ts 100.00% <0.00%> (ø)
...ects/addon-table/directives/table-filters/index.ts 100.00% <0.00%> (ø)
...tools/highlight-color/highlight-color.component.ts 50.00% <0.00%> (ø)
... and 1091 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 331158a into main Nov 10, 2022
@splincode splincode deleted the splincode/feat/issues/3034 branch November 10, 2022 08:58
@well-done-bot
Copy link

well-done-bot bot commented Nov 10, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

UIKIT-6174
3 participants