Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-editor): support write simple text after marked link #3021

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2970

What is the new behavior?

Screen.Recording.2022-11-07.at.14.29.54.mov

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 7, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Visit the preview URL for this PR (updated for commit dd1ae3f):

https://taiga-ui--pr3021-splincode-fix-issues-76jaxjwq.web.app

(expires Tue, 08 Nov 2022 10:51:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Nov 7, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
323.26KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.05KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.17MB (+216B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 0.00% // Head: 51.34% // Increases project coverage by +51.34% 🎉

Coverage data is based on head (166c09b) compared to base (c2aac4b).
Patch coverage: 33.33% of modified lines in pull request are covered.

❗ Current head 166c09b differs from pull request most recent head dd1ae3f. Consider uploading reports for the commit dd1ae3f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3021       +/-   ##
=========================================
+ Coverage      0   51.34%   +51.34%     
=========================================
  Files         0      159      +159     
  Lines         0     1788     +1788     
  Branches      0      229      +229     
=========================================
+ Hits          0      918      +918     
- Misses        0      829      +829     
- Partials      0       41       +41     
Flag Coverage Δ
addon-editor 51.34% <33.33%> (?)
summary 51.34% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...don-editor/components/toolbar/toolbar.component.ts 13.09% <ø> (ø)
projects/addon-editor/extensions/link/link.ts 23.07% <23.07%> (ø)
...ult-editor-extensions/default-editor-extensions.ts 100.00% <100.00%> (ø)
projects/addon-editor/extensions/link/index.ts 100.00% <100.00%> (ø)
...n-editor/extensions/table-cell-background/index.ts 100.00% <0.00%> (ø)
...ols/table-cell-color/table-cell-color.component.ts 44.44% <0.00%> (ø)
projects/addon-editor/utils/delete-nodes.ts 11.11% <0.00%> (ø)
...bar-tools/align-content/align-content.component.ts 63.63% <0.00%> (ø)
...cts/addon-editor/directives/tiptap-editor/index.ts 100.00% <0.00%> (ø)
...olbar-tools/table-create/table-create.component.ts 43.75% <0.00%> (ø)
... and 151 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/issues/2970 branch from 166c09b to dd1ae3f Compare November 7, 2022 10:44
@splincode splincode merged commit a2f0123 into main Nov 7, 2022
@splincode splincode deleted the splincode/fix/issues/2970 branch November 7, 2022 11:52
@well-done-bot
Copy link

well-done-bot bot commented Nov 7, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Editor link
3 participants