Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-commerce): fix safari expire autofill #3015

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3013

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 3, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 3, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
323.26KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.05KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Visit the preview URL for this PR (updated for commit 4b7e01c):

https://taiga-ui--pr3015-input-card-fix-hh0ijmtm.web.app

(expires Fri, 04 Nov 2022 15:46:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 61.88% // Head: 61.88% // No change to project coverage 👍

Coverage data is based on head (4b7e01c) compared to base (0a68461).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3015   +/-   ##
=======================================
  Coverage   61.88%   61.88%           
=======================================
  Files        1483     1483           
  Lines       17561    17561           
  Branches     2395     2395           
=======================================
  Hits        10868    10868           
  Misses       6253     6253           
  Partials      440      440           
Flag Coverage Δ
addon-charts 72.48% <0.00%> (ø)
addon-doc 48.46% <ø> (ø)
addon-editor 51.59% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 64.06% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.26% <ø> (ø)
core 76.79% <ø> (ø)
kit 74.11% <ø> (ø)
summary 61.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ommerce/utils/create-auto-corrected-expire-pipe.ts 59.09% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin merged commit c2aac4b into main Nov 7, 2022
@vladimirpotekhin vladimirpotekhin deleted the input-card-fix branch November 7, 2022 06:49
@well-done-bot
Copy link

well-done-bot bot commented Nov 7, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - InputCardGroupped safari error
3 participants