feat(cdk): implement tuiIsPresent pipe
#3002
Conversation
theorlovsky
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +242B +0.04% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportBase: 61.88% // Head: 61.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3002 +/- ##
==========================================
- Coverage 61.88% 61.87% -0.02%
==========================================
Files 1483 1490 +7
Lines 17561 17602 +41
Branches 2395 2401 +6
==========================================
+ Hits 10868 10891 +23
- Misses 6253 6273 +20
+ Partials 440 438 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
theorlovsky
requested review from
splincode
and removed request for
MarsiBarsi,
waterplea,
nsbarsukov and
vladimirpotekhin
|
I think a nice example would be something like: <div *ngIf="count$ | async | tuiIsPresent as value">showing how this can be used for falsy values like |
| } | ||
|
|
||
| private objectifyValue(value: string): string | null | undefined { | ||
| if (value === `null`) { |
There was a problem hiding this comment.
nit: Looks like a job for switch :)
There was a problem hiding this comment.
do you want to keep this example or completely replace it with the one above?
There was a problem hiding this comment.
I went ahead and replaced it since the new example is more useful 🙂
There was a problem hiding this comment.
@waterplea please check if it's not too complicated
There was a problem hiding this comment.
Looks great. Thank you!
theorlovsky
force-pushed
the
is-present
branch
from
59aae7f to
d888687
Compare
|
|
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?