Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): fix incorrect project name search #2962

Merged

Conversation

festimprebreza
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

The script gets the absolute path of the file, so if another folder (except for our Taiga projects folder) in that path was named projects the script would incorrectly resolve the package name to that folders child name.

What is the new behavior?

Now we check for the regex match only relative to our working directory.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 25, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 26, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
320.58KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.02KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 61.79% // Head: 61.79% // No change to project coverage 👍

Coverage data is based on head (381ebbb) compared to base (3c219c1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2962   +/-   ##
=======================================
  Coverage   61.79%   61.79%           
=======================================
  Files        1473     1473           
  Lines       17403    17403           
  Branches     2364     2364           
=======================================
  Hits        10754    10754           
  Misses       6210     6210           
  Partials      439      439           
Flag Coverage Δ
addon-charts 72.48% <ø> (ø)
addon-doc 48.46% <ø> (ø)
addon-editor 53.20% <ø> (ø)
addon-mobile 61.68% <ø> (ø)
addon-table 64.06% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.28% <ø> (ø)
core 76.23% <ø> (ø)
kit 73.63% <ø> (ø)
summary 61.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode marked this pull request as ready for review October 28, 2022 08:52
@splincode splincode added the community contribution This issue was closed by a PR from the community label Oct 28, 2022
@splincode splincode merged commit dfbb09e into taiga-family:main Oct 28, 2022
@well-done-bot
Copy link

well-done-bot bot commented Oct 28, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Development

Successfully merging this pull request may close these issues.

3 participants