Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Button add padding customization #2932

Merged
merged 1 commit into from
Oct 20, 2022
Merged

feat(core): Button add padding customization #2932

merged 1 commit into from
Oct 20, 2022

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 20, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 6336ccd):

https://taiga-ui--pr2932-filter-e423xw47.web.app

(expires Fri, 21 Oct 2022 09:52:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Oct 20, 2022

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
34.05KB (+105B +0.3%) +10%
demo/browser/main.(hash).js
319.11KB (+26B +0.01%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +131B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (+3.87KB +0.17%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 61.81% // Head: 69.01% // Increases project coverage by +7.20% 🎉

Coverage data is based on head (6336ccd) compared to base (214fc30).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
+ Coverage   61.81%   69.01%   +7.20%     
==========================================
  Files        1471     1085     -386     
  Lines       17377    13019    -4358     
  Branches     2354     1796     -558     
==========================================
- Hits        10741     8985    -1756     
+ Misses       6198     3727    -2471     
+ Partials      438      307     -131     
Flag Coverage Δ
addon-charts 72.48% <ø> (ø)
addon-doc 48.38% <ø> (ø)
addon-editor 53.20% <ø> (ø)
addon-mobile 61.68% <ø> (ø)
addon-table 64.06% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk ∅ <ø> (∅)
core 76.26% <ø> (ø)
kit 73.68% <ø> (ø)
summary 69.01% <ø> (+7.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cts/cdk/observables/items-query-list-observable.ts
...jects/cdk/utils/dom/get-document-or-shadow-root.ts
projects/cdk/directives/focused/focused.module.ts
projects/cdk/coercion/coerce-boolean-property.ts
projects/cdk/directives/autofilled/index.ts
.../directives/auto-focus/handlers/default.handler.ts
projects/cdk/constants/svg-node-filter.ts
projects/cdk/directives/zoom/zoom.module.ts
.../cdk/directives/overscroll/overscroll.directive.ts
projects/cdk/utils/color/hsv-to-rgb.ts
... and 376 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea waterplea merged commit 91c1b81 into main Oct 20, 2022
@waterplea waterplea deleted the filter branch October 20, 2022 11:38
@well-done-bot
Copy link

well-done-bot bot commented Oct 20, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants