Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-editor): add anchor extension #2931

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Conversation

splincode
Copy link
Member

@splincode splincode commented Oct 20, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2456

What is the new behavior?

Screen.Recording.2022-10-20.at.12.46.52.mov
New screenshots / All

1-editors anchors editor snap

New screenshots 1

1-editors anchors anchors anchor is #moser snap

New screenshots 2

1-editors anchors anchors anchor is #thirlwell snap

New screenshots 3

1-editors anchors anchors anchor is #briggs snap

New screenshots 4

1-editors anchors anchors anchor is #introduction snap

New screenshots 5

1-editors anchors anchors anchor is #knowles snap

New screenshots 6

1-editors anchors anchors anchor is #war snap

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 20, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/fix/editor branch from 9556678 to ac52260 Compare October 20, 2022 08:00
@bundlemon
Copy link

bundlemon bot commented Oct 20, 2022

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
323.26KB (+1.25KB +0.39%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.05KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +1.25KB +0.21%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (+2.7KB +0.12%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

Visit the preview URL for this PR (updated for commit 2386aca):

https://taiga-ui--pr2931-splincode-fix-editor-f2e4ekk9.web.app

(expires Tue, 01 Nov 2022 12:01:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 62.02% // Head: 68.79% // Increases project coverage by +6.77% 🎉

Coverage data is based on head (0c964fb) compared to base (89af6a9).
Patch coverage: 14.28% of modified lines in pull request are covered.

❗ Current head 0c964fb differs from pull request most recent head 2386aca. Consider uploading reports for the commit 2386aca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
+ Coverage   62.02%   68.79%   +6.77%     
==========================================
  Files        1481     1090     -391     
  Lines       17499    13073    -4426     
  Branches     2376     1810     -566     
==========================================
- Hits        10854     8994    -1860     
+ Misses       6208     3765    -2443     
+ Partials      437      314     -123     
Flag Coverage Δ
addon-charts 72.48% <ø> (ø)
addon-doc 48.38% <ø> (-0.09%) ⬇️
addon-editor 52.06% <14.28%> (-0.60%) ⬇️
addon-mobile 61.68% <ø> (-0.63%) ⬇️
addon-table 64.06% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk ∅ <ø> (∅)
core 76.26% <ø> (-0.53%) ⬇️
kit 73.68% <ø> (-0.44%) ⬇️
summary 68.79% <14.28%> (+6.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/addon-editor/abstract/editor-adapter.abstract.ts 60.00% <ø> (ø)
...editor/components/edit-link/edit-link.component.ts 12.96% <0.00%> (-3.32%) ⬇️
...addon-editor/components/editor/editor.component.ts 28.26% <0.00%> (-1.29%) ⬇️
...don-editor/components/toolbar/toolbar.component.ts 12.94% <0.00%> (-1.17%) ⬇️
.../directives/tiptap-editor/tiptap-editor.service.ts 9.09% <0.00%> (-0.29%) ⬇️
...jects/addon-editor/extensions/jump-anchor/index.ts 0.00% <0.00%> (ø)
...or/extensions/jump-anchor/jump-anchor.extension.ts 0.00% <0.00%> (ø)
...or/directives/jump-anchor/jump-anchor.directive.ts 22.22% <22.22%> (ø)
projects/addon-editor/directives/index.ts 100.00% <100.00%> (ø)
...jects/addon-editor/directives/jump-anchor/index.ts 100.00% <100.00%> (ø)
... and 435 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/editor branch 6 times, most recently from ede77bd to 34078f0 Compare October 21, 2022 16:20
@splincode splincode force-pushed the splincode/fix/editor branch 2 times, most recently from bdae375 to e28c58d Compare October 28, 2022 08:52
@splincode splincode requested a review from waterplea October 28, 2022 08:54
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@splincode splincode force-pushed the splincode/fix/editor branch from e28c58d to b379e74 Compare October 30, 2022 18:11
@splincode splincode force-pushed the splincode/fix/editor branch 2 times, most recently from 8093ac3 to 42e815a Compare October 31, 2022 11:25
@splincode splincode requested a review from nsbarsukov October 31, 2022 11:25
@splincode splincode force-pushed the splincode/fix/editor branch from 42e815a to e62d907 Compare October 31, 2022 11:27
@splincode splincode force-pushed the splincode/fix/editor branch from e62d907 to 2386aca Compare October 31, 2022 11:57
@splincode splincode merged commit 1e3a22a into main Oct 31, 2022
@splincode splincode deleted the splincode/fix/editor branch October 31, 2022 12:38
@well-done-bot
Copy link

well-done-bot bot commented Oct 31, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Add example anchor inside article in new editor
4 participants