Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): ProgressBar add :indeterminate-state #2876

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2725

What is the new behavior?

indeterminate-progress

Does this PR introduce a breaking change?

  • Yes
  • No

@nsbarsukov nsbarsukov self-assigned this Oct 12, 2022
@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 12, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 12, 2022

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+317.53KB +10%
demo/browser/vendor.(hash).js
+205.42KB +10%
demo/browser/runtime.(hash).js
+33.64KB +10%
demo/browser/polyfills.(hash).js
+19.92KB +10%
demo/browser/scripts.(hash).js
+14.92KB +10%

Total files change +591.43KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.14MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Visit the preview URL for this PR (updated for commit 61b888b):

https://taiga-ui--pr2876-progress-indetermina-7df4gdy8.web.app

(expires Thu, 13 Oct 2022 13:51:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 61.77% // Head: 61.77% // No change to project coverage 👍

Coverage data is based on head (61b888b) compared to base (1988491).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2876   +/-   ##
=======================================
  Coverage   61.77%   61.77%           
=======================================
  Files        1462     1462           
  Lines       17319    17319           
  Branches     2351     2351           
=======================================
  Hits        10699    10699           
  Misses       6180     6180           
  Partials      440      440           
Flag Coverage Δ
addon-charts 72.41% <ø> (ø)
addon-doc 48.38% <ø> (ø)
addon-editor 53.20% <ø> (ø)
addon-mobile 61.73% <ø> (ø)
addon-table 64.43% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.30% <ø> (ø)
core 76.33% <ø> (ø)
kit 73.62% <ø> (ø)
summary 61.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nsbarsukov nsbarsukov changed the title [WIP] feat(kit): ProgressBar add :indeterminate-state feat(kit): ProgressBar add :indeterminate-state Oct 12, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review October 12, 2022 13:16
@nsbarsukov nsbarsukov merged commit e311069 into main Oct 12, 2022
@nsbarsukov nsbarsukov deleted the progress-indeterminate-state branch October 12, 2022 15:58
@well-done-bot
Copy link

well-done-bot bot commented Oct 12, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Add indeterminate option for progress bar
3 participants