Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-editor): normalize h1-h6 heading in editor socket #2808

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

splincode
Copy link
Member

@splincode splincode commented Oct 5, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2718

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 5, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Visit the preview URL for this PR (updated for commit 3a3a5e8):

https://taiga-ui--pr2808-splincode-fix-issues-1nm8uug2.web.app

(expires Thu, 06 Oct 2022 12:47:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 39.94% // Head: 39.94% // No change to project coverage 👍

Coverage data is based on head (3a3a5e8) compared to base (a59afe8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2808   +/-   ##
=======================================
  Coverage   39.94%   39.94%           
=======================================
  Files         958      958           
  Lines        9247     9247           
  Branches     1900     1900           
=======================================
  Hits         3694     3694           
  Misses       5349     5349           
  Partials      204      204           
Flag Coverage Δ
addon-charts 73.77% <ø> (ø)
addon-doc 18.72% <ø> (ø)
addon-editor 28.64% <ø> (ø)
addon-mobile ?
addon-table 83.78% <ø> (ø)
addon-tablebars ?
cdk 62.87% <ø> (ø)
core 60.90% <ø> (ø)
kit 19.18% <ø> (ø)
summary 39.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/issues/2718 branch from 9b86b64 to 3a3a5e8 Compare October 5, 2022 12:43
@splincode splincode merged commit c8ff2d2 into main Oct 6, 2022
@splincode splincode deleted the splincode/fix/issues/2718 branch October 6, 2022 07:44
@well-done-bot
Copy link

well-done-bot bot commented Oct 6, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Incorrect line-height styles for h1 and h2 tags in editor
3 participants