Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-editor): removing all !important styles #2798

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2754

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 3, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Visit the preview URL for this PR (updated for commit dfc4c02):

https://taiga-ui--pr2798-splincode-fix-issues-opwtbjxh.web.app

(expires Tue, 04 Oct 2022 14:25:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 56.26% // Head: 56.26% // No change to project coverage 👍

Coverage data is based on head (dfc4c02) compared to base (0027332).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2798   +/-   ##
=======================================
  Coverage   56.26%   56.26%           
=======================================
  Files         957      957           
  Lines        9240     9240           
  Branches     1895     1895           
=======================================
  Hits         5199     5199           
  Misses       3625     3625           
  Partials      416      416           
Flag Coverage Δ
addon-charts 73.77% <ø> (ø)
addon-doc 18.72% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <100.00%> (ø)
core 60.90% <ø> (ø)
kit 61.53% <ø> (ø)
summary 56.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/cdk/constants/version.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/issues/2754 branch from d0544c1 to fbbb264 Compare October 3, 2022 12:30
@splincode splincode force-pushed the splincode/fix/issues/2754 branch from fbbb264 to dfc4c02 Compare October 3, 2022 14:20
@vladimirpotekhin
Copy link
Member

seems that the last screenshot is not ok

@waterplea
Copy link
Collaborator

seems that the last screenshot is not ok

I thought it got fixed, seems like the code block should be like on the left screenshot.

@splincode splincode merged commit a59afe8 into main Oct 5, 2022
@splincode splincode deleted the splincode/fix/issues/2754 branch October 5, 2022 08:45
@well-done-bot
Copy link

well-done-bot bot commented Oct 5, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - .tui-editor-socket
3 participants