Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): Stackblitz broken styles #2747

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix(demo): Stackblitz broken styles #2747

merged 1 commit into from
Sep 23, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

The vast majority of components have problems with styles inside Stackblitz.

Some examples:
https://taiga-ui.dev/components/input#modes
Screenshot 2022-09-22 at 16 26 33


https://taiga-ui.dev/components/button#appearance
Screenshot 2022-09-22 at 16 20 20


https://taiga-ui.dev/components/input-slider#base
Screenshot 2022-09-22 at 16 24 45

What is the new behavior?

https://taiga-ui.dev/components/input#modes
Screenshot 2022-09-22 at 16 28 30


https://taiga-ui.dev/components/button#appearance
Screenshot 2022-09-22 at 16 20 46


https://taiga-ui.dev/components/input-slider#base
Screenshot 2022-09-22 at 16 24 26

The global styles will be fixed later!

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 22, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@nsbarsukov nsbarsukov linked an issue Sep 22, 2022 that may be closed by this pull request
9 tasks
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 17ddc96):

https://taiga-ui--pr2747-stackblitz-styles-fi-uenuweq7.web.app

(expires Fri, 23 Sep 2022 13:33:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 56.67% // Head: 56.67% // No change to project coverage 👍

Coverage data is based on head (17ddc96) compared to base (f938d49).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2747   +/-   ##
=======================================
  Coverage   56.67%   56.67%           
=======================================
  Files         956      956           
  Lines        9237     9237           
  Branches     1894     1894           
=======================================
  Hits         5235     5235           
  Misses       3591     3591           
  Partials      411      411           
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.12% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 62.86% <ø> (ø)
kit 61.50% <ø> (ø)
summary 56.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nsbarsukov nsbarsukov merged commit 1bf9e2d into main Sep 23, 2022
@nsbarsukov nsbarsukov deleted the stackblitz-styles-fix branch September 23, 2022 07:41
@well-done-bot
Copy link

well-done-bot bot commented Sep 23, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Stackblitz and Taiga UI v3.0
3 participants